fix(react): key custom page portals by stable id#8730
Merged
jacekradko merged 1 commit intoJun 2, 2026
Merged
Conversation
CustomPortalsRenderer keyed portals by array index, so adding, removing, or reordering custom pages remounted the survivors even though their portal identity was stable. Each portal now carries a stable key derived from its portalId, so React reconciles a moved page as an update. Includes jsdom and e2e coverage for the remount behavior.
🦋 Changeset detectedLatest commit: 91b4771 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jacekradko
merged commit 93d045e
into
je/orgprofile-custom-pages-rendering-bug
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the custom-page remount fix. That change stabilized each portal's identity so a custom page survives a parent rerender; this goes one step further.
CustomPortalsRendererwas still keying portals by array index, so adding, removing, or reordering pages remounted the survivors anyway. Each portal now carries a stable key from itsportalId, so a page that moves position reconciles as an update.The hooks now emit
{ key, portal }(withcontent:/label:/icon:prefixes so a page's two portals stay distinct). Coverage added: a jsdom integration test that renders through the real portal path (no remount on a parent rerender or an insert), and an e2e test that a custom page keeps its local state across a parent rerender.