Skip to content

chore(expo): Mention config plugin in Google Sign-In migration notice#9019

Merged
wobsoriano merged 1 commit into
mainfrom
rob/expo-migration-google-update
Jun 28, 2026
Merged

chore(expo): Mention config plugin in Google Sign-In migration notice#9019
wobsoriano merged 1 commit into
mainfrom
rob/expo-migration-google-update

Conversation

@wobsoriano

@wobsoriano wobsoriano commented Jun 28, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Clarified Google Sign-In migration guidance across app warnings and docs.
    • Added a reminder to install the required Expo config plugin when using native Google Sign-In.
    • Kept the existing import path note, so current setups continue to work during the transition.
  • Chores

    • Updated the release note entry to mark the change as a patch update.

@changeset-bot

changeset-bot Bot commented Jun 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 27bc215

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jun 28, 2026 12:18am
swingset Ready Ready Preview, Comment Jun 28, 2026 12:18am

Request Review

@wobsoriano wobsoriano requested a review from mikepitre June 28, 2026 00:16
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 838816fb-3c17-4393-ba7a-f65a1a2b3ff2

📥 Commits

Reviewing files that changed from the base of the PR and between ec709ee and 27bc215.

📒 Files selected for processing (6)
  • .changeset/fresh-masks-warn-google-plugin.md
  • packages/expo/src/hooks/__tests__/useSignInWithGoogle.test.ts
  • packages/expo/src/hooks/useSignInWithGoogle.android.ts
  • packages/expo/src/hooks/useSignInWithGoogle.ios.ts
  • packages/expo/src/hooks/useSignInWithGoogle.shared.ts
  • packages/expo/src/hooks/useSignInWithGoogle.ts

📝 Walkthrough

Walkthrough

Updates the migration warning message for native Google Sign-In across useSignInWithGoogle hooks (Android, iOS, shared, and stub) to instruct users to install @clerk/expo-google-signin and add its Expo config plugin. The matching test assertion and changeset are updated accordingly.

Google Sign-In config plugin warning

Layer / File(s) Summary
Warning text, docs, and test update
packages/expo/src/hooks/useSignInWithGoogle.shared.ts, packages/expo/src/hooks/useSignInWithGoogle.android.ts, packages/expo/src/hooks/useSignInWithGoogle.ios.ts, packages/expo/src/hooks/useSignInWithGoogle.ts, packages/expo/src/hooks/__tests__/useSignInWithGoogle.test.ts, .changeset/fresh-masks-warn-google-plugin.md
The runtime console.warn and all JSDoc comments now specify installing the @clerk/expo-google-signin Expo config plugin in addition to the package itself; the test expectation and changeset are updated to match.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • clerk/javascript#8991: Introduced the same "native Google Sign-In migration" warning in useSignInWithGoogle; this PR extends that warning to also reference the Expo config plugin.

Suggested reviewers

  • mikepitre

🐇 A hop, a skip, a plugin to add,
The warning now tells you what once was sad.
Install the package, configure the plug,
No missing steps — just a bunny's shrug!
Google Sign-In, now properly clad! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding config-plugin guidance to the Expo Google Sign-In migration notice.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jun 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9019

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9019

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9019

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9019

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9019

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9019

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9019

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9019

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9019

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9019

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9019

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9019

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9019

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9019

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9019

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9019

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9019

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9019

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9019

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9019

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9019

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9019

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9019

commit: 27bc215

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-28T00:19:08.907Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 27bc215.

@wobsoriano wobsoriano merged commit de70b28 into main Jun 28, 2026
58 checks passed
@wobsoriano wobsoriano deleted the rob/expo-migration-google-update branch June 28, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants