fix(clerk-react): Memoize useAuth.getToken and useAuth.signOut#980
Merged
nikosdouvlis merged 1 commit intomainfrom Mar 24, 2023
Merged
fix(clerk-react): Memoize useAuth.getToken and useAuth.signOut#980nikosdouvlis merged 1 commit intomainfrom
nikosdouvlis merged 1 commit intomainfrom
Conversation
JS-282 Memoize useAuth.getToken
getToken is not memoized, so we return a new function reference every time useAuth rerenders. Notify the Convex team and the related github issue |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
dimkl
approved these changes
Mar 24, 2023
| get session(): ActiveSessionResource | undefined | null { | ||
| if (this.clerkjs) { | ||
| return this.clerkjs.session; | ||
| // TODO: add ssr condition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastifygatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Memoize the values of useAuth getToken and signOut
Closes #201
Closes #455