Merged
Conversation
samcoe
approved these changes
Oct 12, 2020
Contributor
samcoe
left a comment
samcoe
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for implementing this 🙇
mislav
approved these changes
Oct 13, 2020
Contributor
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Fantastic! Thank you for the feature and the test updates 💖
mloskot
added a commit
to mloskot/minikube
that referenced
this pull request
Jan 28, 2026
Utilization of `gh auth status` to obtain the token is a legacy method, cli/cli#2157 which was replaced with `gh auth token` command, cli/cli#6324
medyagh
pushed a commit
to kubernetes/minikube
that referenced
this pull request
Jan 30, 2026
Utilization of `gh auth status` to obtain the token is a legacy method, cli/cli#2157 which was replaced with `gh auth token` command, cli/cli#6324
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if I need to change anything. I noticed that the
hostname settest case was duplicated so I removed that.Closes #1514