Added typehints and mypy test env in tox #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal_commands' checks whether its an internal command or not, to make every callback function for every internal command takes no arguments and return None
…tisfy mypy Using isinstance check with (Sequence, Generator, Iterator) rather than with (Mapping, Iterable) for aliases of an internal command: click_repl/utils.py
Updated testing dependencies to include flake8 and mypy: setup.cfg
auvipy
requested changes
Jan 15, 2025
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
can you do another round to see if all the types are updated here?
auvipy
requested changes
Apr 16, 2025
|
|
||
| val = formatter.getvalue() # type: str | ||
| return val | ||
| print(formatter.getvalue()) |
Collaborator
There was a problem hiding this comment.
I think we should get rid of the print() and return it like before. what is your thoughts on this?
auvipy
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds typehints to the existing code, and added mypy test env in tox to perform type checking in GHA
Also, changed
click_repl.utils._help_internalfunction to just print the help text, rather than returning it, so that all function callbacks for internal command can be in the same type ofCallable[[], None]