Skip to content

Add options to advanced popups #32

@FifthTundraG

Description

@FifthTundraG

Advanced popups are great, but there's a lot you can't do with them. One thing that annoys me about them is that you can't add padding to the popup without doing a bunch of gymnastics with JS. Another thing that I recently thought would be a beneficial addition would be to be able to change the level of filter that appears when the popup is present (idk if this is actually possible or not). Then there's also the filter parameter that was removed, but for a time I've been planning on re-implementing it. With this many ideas for how to configure the functionality of an advanced popup, we'll very quickly start stacking massive amounts of parameters on the helper.popup.createAdvanced() function. To fix this, I propose that we have only one parameter, options, that will be an object containing various configuration options for the popup. Here is an example of the interface for this object:

interface AdvancedPopupOptions {
    showFilter: boolean;
    filterLevel: number;
    innerPadding: number;
}

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions