-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Closed
Labels
backward compatibilityeasy taskGood for first contributorsGood for first contributorshelp wantedst-fixed
Description
Describe the issue
We've updated from 21.3.4.25 to 21.8.3.44 and Prometheus metrics are broken now.
According to official Prometheus documentation,
The metric name specifies the general feature of a system that is measured (e.g. http_requests_total - the total number of HTTP requests received). It may contain ASCII letters and digits, as well as underscores and colons. It must match the regex [a-zA-Z_:][a-zA-Z0-9_:]*.
Here is the list of bad names:
# TYPE ClickHouseAsyncMetrics_BlockInFlightOps_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockDiscardTime_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockReadTime_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockDiscardMerges_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockReadMerges_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockDiscardOps_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockWriteOps_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockReadOps_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockReadBytes_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockWriteBytes_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockQueueTime_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockWriteTime_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockActiveTime_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockWriteMerges_dm-1 gauge
# TYPE ClickHouseAsyncMetrics_BlockDiscardBytes_dm-1 gauge
capricornusx, ekbfh, zyclonite and tahajahangir
Metadata
Metadata
Assignees
Labels
backward compatibilityeasy taskGood for first contributorsGood for first contributorshelp wantedst-fixed