Skip to content
This repository was archived by the owner on Apr 23, 2023. It is now read-only.

Clicky/crashdoc#40

Merged
clicky merged 44 commits into
mainfrom
clicky/crashdoc
Mar 5, 2023
Merged

Clicky/crashdoc#40
clicky merged 44 commits into
mainfrom
clicky/crashdoc

Conversation

@clicky

@clicky clicky commented Feb 20, 2023

Copy link
Copy Markdown
Owner

Description

This PR Changes a lot. The goal is to allow for rapid, prototyping, changes and development of Crash. As well as making it easier for others to contribute. I want each release to be more stable than the last. And this should go a long way towards this

  • Refactored Crash into defined layers. The defined separation of Rhino/Not Rhino should really improve Unit Testing and further Architectural decisions.
    • Crash
    • Crash.Handlers
      ---- Rhino boundary ---
    • Crash.Common
    • Crash.Changes
  • Made Crash ready to be Multi-Document Compatible
    • Created CrashDoc and a Registry
  • Defined the Change Class and ChangeActions
  • Created Unit Tests
  • Improved readibility of Code
  • Improved Documentation and docstrings
  • Added .editorconfig
  • Abstracted quite a lot, should make Plugins easier
  • Added some Geometry classes. These should help make the serialization lightning fast and improve Architectural boundaries
  • Moved to System.Text.Json
  • Added more IChange interfaces. These still need some work
  • Abstracted the Draw, AddTo and RemoveFrom Doc of Changes
  • Improved async

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Created new Unit Tests

Checklist:

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the docs
  • My changes generate no new warnings

@clicky clicky linked an issue Feb 20, 2023 that may be closed by this pull request
@clicky

clicky commented Mar 5, 2023

Copy link
Copy Markdown
Owner Author

You can't make a omelette without scrambling a few eggs. Everything is very readable and pretty. Lots of stuff doesn't work anymore, but that's fine. We'll fix it. All the pieces are there.

@clicky clicky marked this pull request as ready for review March 5, 2023 20:27
@clicky clicky merged commit a5dc4b5 into main Mar 5, 2023
@clicky clicky deleted the clicky/crashdoc branch March 5, 2023 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Mac support

1 participant