-
Notifications
You must be signed in to change notification settings - Fork 879
feat(joint-react): paper provider #2971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d context management and options handling
…DME for clarity and usability
kumilingus
reviewed
May 29, 2025
kumilingus
reviewed
May 29, 2025
bd13e01 to
334de3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(joint-react): introduce PaperProvider and unify Paper context handling
🔗 https://github.com/orgs/clientIO/projects/6/views/13?pane=issue&itemId=112378942
Description
This PR introduces a new
<PaperProvider>component and refactors how thePapercomponent interacts with context. This provides more flexible, explicit control over the paper instance in complex React applications.Changes
PaperProviderfor managing shared paper contextPaperto consume existing context fromPaperProvider, or fallback to self-managed contextPapernow reuses the nearest<PaperProvider>in the treeWhen using
PaperProvider, any paper options passed directly to<Paper />are ignored — a console warning will now inform the developer of this to prevent confusionPaperContext, hooks, and providersUsage of
PaperProvider