fix(Model): trigger the changeId event only if prevId is different from this.id#3147
Merged
kumilingus merged 2 commits intoclientIO:masterfrom Jan 26, 2026
Merged
Conversation
kumilingus
approved these changes
Jan 26, 2026
kumilingus
pushed a commit
to kumilingus/joint
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the
changeIdevent was being triggered even when the ID attribute wasn't actually changed. The fix adds a check to only trigger the event when the previous ID differs from the new ID.Motivation and Context
Previously, setting a model's ID to the same value would still trigger the
changeIdevent, which is incorrect behavior. This could cause unnecessary event handlers to fire and lead to unexpected side effects in applications relying on this event.