fix(dia.Paper): handle element removal during pointer events#3151
Merged
kumilingus merged 8 commits intoclientIO:masterfrom Feb 4, 2026
Merged
fix(dia.Paper): handle element removal during pointer events#3151kumilingus merged 8 commits intoclientIO:masterfrom
kumilingus merged 8 commits intoclientIO:masterfrom
Conversation
kumilingus
reviewed
Jan 30, 2026
kumilingus
approved these changes
Feb 4, 2026
kumilingus
requested changes
Feb 4, 2026
Contributor
kumilingus
left a comment
There was a problem hiding this comment.
the second test is not removing the element at all.
kumilingus
approved these changes
Feb 4, 2026
kumilingus
pushed a commit
to kumilingus/joint
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pointermoveorpointerupevent handlers would cause errorsfindViewByModel()returns null (because the model was removed), falls back to using the original view referenceProblem
When an element is removed from the graph during a pointer event handler (e.g., deleting an element after dragging), subsequent calls to
view.pointermove()orview.pointerup()would fail becausefindViewByModel(view.model)returnsundefinedfor removed models.Solution
Added a fallback to use the original view reference when
findViewByModel()returns falsy:This change is applied to both
pointermoveandpointeruphandlers inpackages/joint-core/src/dia/Paper.mjs.