types(joint-core): add useModelGeometry to bbox/rectangle connection point types#3273
Merged
Geliogabalus merged 2 commits intoclientIO:masterfrom Apr 14, 2026
Merged
Conversation
kumilingus
changed the title
…int types Add `BBoxConnectionPointArguments` and `RectangleConnectionPointArguments` with `useModelGeometry` property. Both bbox and rectangle connection points support this option at runtime but the types were missing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kumilingus
force-pushed
the
feat/core-type-fixes
branch
from
ed693bf to
7b9574a
Compare
Link.Attributes now correctly types source/target as optional, so getTargetOrSource must accept undefined. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Geliogabalus
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
BBoxConnectionPointArgumentsandRectangleConnectionPointArgumentsinterfaces withuseModelGeometryproperty. Bothbboxandrectangleconnection points support this option at runtime but the types were missing — users had to cast to use it.BoundaryConnectionPointArgumentsdoes NOT getuseModelGeometryas the boundary connection point does not support it.Changes
packages/joint-core/types/joint.d.ts— add new interfaces, updateConnectionPointArgumentsMap🤖 Generated with Claude Code