refactor(joint-core): remove this-context dependency from link anchors#3274
Merged
Geliogabalus merged 1 commit intoclientIO:masterfrom Apr 14, 2026
Merged
Conversation
kumilingus
force-pushed
the
feat/link-anchors-no-this-context
branch
from
9b90150 to
9d38601
Compare
Use the linkView parameter instead of relying on `this` context in resolveRef(), so link anchor functions can be called directly without needing `.call(linkView, ...)`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kumilingus
force-pushed
the
feat/link-anchors-no-this-context
branch
from
9d38601 to
41684e9
Compare
Geliogabalus
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thisreferences with thelinkViewparameter inresolveRef()wrapper for link anchor functionsconnectionPerpendicular,connectionClosest) can now be called directly asanchor(view, magnet, ref, opt, endType, linkView)without needing.call(linkView, ...)Test plan
connectionPerpendicularandconnectionClosestproduce same results as before🤖 Generated with Claude Code