types(dia.Paper): add CellViewCallback type for elementView/linkView#3283
Merged
Geliogabalus merged 1 commit intoApr 20, 2026
Merged
Conversation
…options Introduce a generic CellViewCallback type in the Paper namespace that infers the model type from the view class. Replaces verbose inline function signatures for elementView and linkView options. Also changes ElementView<any>/LinkView<any> to ElementView<Element>/ LinkView<Link> for stricter typing while still accepting custom subclasses. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Geliogabalus
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paper.CellViewCallback<V>type that infers the model type from the view classelementView/linkViewoption signatures using the new typeElementView<any>/LinkView<any>toElementView<Element>/LinkView<Link>for stricter typing (custom subclasses still accepted via covariance)🤖 Generated with Claude Code