feat(dia.CellView): add computeNodeBoundingRect method#3284
Merged
Geliogabalus merged 1 commit intoApr 20, 2026
Conversation
Extract node bounding rect measurement into a public `computeNodeBoundingRect()` method on CellView. The method computes the pre-rotation bounding rectangle for both SVG and HTML nodes, and warns when a node is not visible. Also relaxes HighlighterView node validation from SVGElement to Element to support HTML highlighters. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Geliogabalus
approved these changes
Apr 20, 2026
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNodeBoundingRectinto a publiccomputeNodeBoundingRect()method on CellViewgetNodeBoundingRect, the result is never cached and the paper'smeasureNodecallback is not consultedcheckVisibility()guard for SVG nodes (previously only checked for HTML nodes) — warns and returns a zero rect when the node is not in the render treeTest plan
🤖 Generated with Claude Code