fix(highlighters): support HTML elements in mask highlighter and node resolution#3285
Merged
Geliogabalus merged 1 commit intoApr 20, 2026
Merged
Conversation
… resolution The mask highlighter now falls back to a rect-based mask for non-SVG nodes (e.g. HTML elements inside foreignObject), matching the existing fallback for text/image elements. Also relaxes HighlighterView.findNode() validation from SVGElement to Element so HTML nodes can be highlighted directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Geliogabalus
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<rect/>mask for HTML nodes (e.g. insideforeignObject), usingV.isSVGGraphicsElement()check — same pattern as text/image elementsHighlighterView.findNode()relaxed fromSVGElementtoElementso HTML nodes can be passed directlyTest plan
HighlighterView.add()🤖 Generated with Claude Code