feat(joint-core): split Cell.JSON / JSONInit, deprecate GenericAttributes#3304
Merged
Conversation
Cell.Attributes now represents visual canvas attributes only (no id, no type). Cell.JSONInit adds id? + type. Cell.JSON keeps id + type required. Renames index sig key from `key` to `customAttribute` for clarity.
Geliogabalus
approved these changes
May 4, 2026
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of the dev PR (#3303) onto master.
Cell.JSON(output oftoJSON, requiresid+type) from newCell.JSONInit(constructor input, requires onlytype); same split forElement/Link.GenericAttributes<T>in favour ofAttributes<T>(kept as emptyinterface … extends Attributes<T>to preserve declaration-merging).Graph.toJSON()return type fromanytoGraph.JSON; symmetrically tightenGraph.fromJSON(json: Graph.JSON, …).Graph.JSONindex signature fromanytounknown.shapes-standard.d.tsto useElement.Attributes/Link.Attributesinstead of deprecatedGenericAttributes.Note: master's pre-existing
Cell.GenericAttributes(withoutparent/layer) was removed by the cherry-pick; the newCell.Attributesincludes both fields, so this is a forward-compatible change.Test plan
yarn test-tspassesyarn workspace @joint/core run lintpassesdia.Element.GenericAttributes<T>declaration-merging still compiles for downstream users🤖 Generated with Claude Code