Cherry-pick rightAngle minPathMargin (#3266) into dev#3305
Merged
kumilingus merged 1 commit intoclientIO:devfrom May 4, 2026
Merged
Cherry-pick rightAngle minPathMargin (#3266) into dev#3305kumilingus merged 1 commit intoclientIO:devfrom
kumilingus merged 1 commit intoclientIO:devfrom
Conversation
…ss margin-overlap detours (clientIO#3266)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
858d04955from master: feat(router): addminPathMarginoption to rightAngle router to suppress margin-overlap detours (feat(router): add minPathMargin option to rightAngle router to suppress margin-overlap detours #3266)6363f39ac— Cell.toJSON predicate) is already in dev via feat(joint-react): paper-transform, linkRouting, useGraph JSON helpers + Cell.toJSON predicate #3298, so it was skipped (empty cherry-pick).Notes
test/jointjs/routers.jswas resolved by keeping only theminMargintests introduced by the cherry-picked commit. The trailing context (rightAngle routing with source anchor outside the element bboxtest) belongs to commit2a1fec504(fix(routers.rightAngle): include anchor in bbox union #3288), which is not part of this cherry-pick and not yet in dev.Test plan
yarn test-server— QUnit router tests passyarn test-ts— types compileyarn lint