fix(joint-core, joint-react): override gridPatterns via getGridPatterns() instead of mutating static property#3330
Merged
kumilingus merged 6 commits intoMay 22, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The previous approach mutated `dia.Paper.gridPatterns` once at import time, making the CSS variable substitution permanent and side-effectful for any code that imported the preset. The new approach is non-destructive: each `GridLayerView` instantiation receives a fresh clone with the override applied, and the static property remains unmodified for downstream consumers.
Test plan
🤖 Generated with Claude Code