refactor(joint-react): rename callback arg types from ...Context to ...Params#3346
Closed
kumilingus wants to merge 1 commit into
Closed
refactor(joint-react): rename callback arg types from ...Context to ...Params#3346kumilingus wants to merge 1 commit into
kumilingus wants to merge 1 commit into
Conversation
…..Params Renames callback argument types whose names collide with React's Context concept. These objects are plain parameter bags, not contexts. Public API breaking change: - ValidateConnectionContext -> ValidateConnectionParams - ValidateEmbeddingContext -> ValidateEmbeddingParams - ValidateUnembeddingContext -> ValidateUnembeddingParams - CellVisibilityContext -> CellVisibilityParams - ConnectionStrategyContext -> ConnectionStrategyParams - InteractiveContext -> InteractiveParams - DefaultLinkContext -> DefaultLinkParams - PortalSelectorContext -> PortalSelectorParams EventContext types (PointerCellEventContext, etc.) are unchanged. Also fixes a broken import in presets/index.ts that referenced ValidateConnectionParams before it existed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
...Contextsuffix collided with React's Context concept. These objects are plain parameter bags, so...Paramsis the more accurate name.presets/index.tsthat referencedValidateConnectionParamsbefore any such name existed.Breaking changes (public API)
ValidateConnectionContextValidateConnectionParamsValidateEmbeddingContextValidateEmbeddingParamsValidateUnembeddingContextValidateUnembeddingParamsCellVisibilityContextCellVisibilityParamsConnectionStrategyContextConnectionStrategyParamsInteractiveContextInteractiveParamsDefaultLinkContextDefaultLinkParamsPortalSelectorContextPortalSelectorParams*EventContexttypes (PointerCellEventContext, etc.) are unchanged.Test plan
yarn typecheck— no rename-related errorsyarn lintyarn jest— 921 / 921 passyarn build—dist/typescontains the new...Paramsnames🤖 Generated with Claude Code