fix(joint-core): backport prototype-pollution guards + widen computeNodeBoundingRect [dev]#3370
Merged
kumilingus merged 1 commit intoJun 15, 2026
Conversation
…odeBoundingRect Backport from master: - `utilHelpers.mjs` — prototype-pollution guards on `set`, `unset`, `assign`, `baseMerge`, `baseAssignValue`, and `safeGet`. Blocks `__proto__`, `constructor`, and `prototype` as traversal/assignment keys. - `dia.d.ts` — widen `computeNodeBoundingRect` parameter from `SVGElement` to `SVGElement | HTMLElement`. Note: `test/jointjs/utilHelpers.js` exists on master but was removed on dev; not restored here.
kumilingus
deleted the
backport/proto-pollution-guards-and-computeNodeBoundingRect
branch
zbynekstara
changed the title
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport from
masterto bringdevin sync on two items:utilHelpers.mjs— prototype-pollution guards onset,unset,assign,baseMerge,baseAssignValue, andsafeGet. Blocks__proto__,constructor, andprototypeas traversal/assignment keys.dia.d.ts— widencomputeNodeBoundingRectparameter fromSVGElementtoSVGElement | HTMLElement.master'sutilHelpers.mjswas checked:devhad no unique commits touching the file, so takingmaster's version wholesale is safe.Notes
test/jointjs/utilHelpers.jsexists onmasterbut was removed ondev. Not restored here — flag if it should be.dia.d.tsoriginX/originYfitToContenttypes unique todevpreserved.Test plan
yarn test-server(joint-core)yarn test-tsset(obj, '__proto__.polluted', true)no-op🤖 Generated with Claude Code