fix: Add secure flag to session middleware cookie configuration#22
Merged
Conversation
Adds 'secure: true' to the express-session cookie configuration to ensure session cookies are only transmitted over HTTPS connections. This prevents session hijacking via man-in-the-middle attacks on HTTP connections. Fixes: javascript.express.security.audit.express-cookie-settings.express-cookie-session-no-secure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated remediation for semgrep finding: Default session middleware settings:
securenot set. It ensures the browser only sends the cookie over HTTPS.Changes
secure: trueflag to the express-session cookie configurationhttpOnly: trueandsecure: true)Impact
Validation
The fix can be verified by:
Generated by OpenSec remediation agent