Skip to content

Fix derivative cosine decay#17

Merged
florence-bockting merged 8 commits intoadd_polynomial_decayfrom
fix_derivative_cosine_decay
Apr 2, 2025
Merged

Fix derivative cosine decay#17
florence-bockting merged 8 commits intoadd_polynomial_decayfrom
fix_derivative_cosine_decay

Conversation

@florence-bockting
Copy link
Contributor

@florence-bockting florence-bockting commented Apr 2, 2025

Description

  • add test that checks that derivative of decay function is computed correctly

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@florence-bockting florence-bockting marked this pull request as ready for review April 2, 2025 10:28
@florence-bockting florence-bockting changed the base branch from main to add_polynomial_decay April 2, 2025 10:33
Copy link
Contributor

@znichollscr znichollscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. A few minor fixes then good to go

@florence-bockting florence-bockting merged commit cffb265 into add_polynomial_decay Apr 2, 2025
19 checks passed
@florence-bockting florence-bockting deleted the fix_derivative_cosine_decay branch April 2, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants