feat: consolidate question sets architecture#5
Merged
suung merged 13 commits intoDec 4, 2025
Conversation
• Add mountain peak themed question sets (Denali, Kilimanjaro) • Add shortcut field to all question sets (ev, tcfd, denali, kilimanjaro) • Consolidate to single source: report_analyst/questionsets/ • Remove hardcoded question set names across all UIs • Implement dynamic loading via QuestionSetLoader • Add 100% test coverage for question loader functionality • Update all imports from app.* to report_analyst.* • Update .gitignore to exclude temp files and artifacts
• Replace hardcoded fallback options with generic approach • Use empty list or custom-only when core functionality unavailable • Add comprehensive test coverage for fallback behavior • Ensure no hardcoded question set names in any fallback paths • Maintain 100% test coverage for question loader module
- Fix get_vectors() to read from document_chunks table instead of non-existent vector_cache - Fix embedding serialization with proper shape and dtype storage - Update clear_cache() to use correct table names - Add 41 comprehensive Streamlit AppTest tests covering all UI functionality - Add single comprehensive GitHub Actions CI workflow with multi-Python testing - Remove duplicate app/ directory after consolidating to report_analyst/ - All 83 tests now pass with 24% coverage
- Update to ubuntu-24.04 runner - Use Python 3.10, 3.11, 3.12 (remove outdated 3.8, 3.9) - Update to actions/setup-python@v5 - Remove Python 3.1 typo that caused failures
- Use string format for Python versions to avoid parsing issues - Change from 3.10 to "3.10" format
- Apply black formatting to all test files - Fix linting issues that were causing CI failures
- Fix pulsar-client version from 3.6.0 to 3.6.1 (version doesn't exist) - Use only Python 3.12 in CI to match local environment - Avoid version conflicts with packages that don't support newer Python versions
- Run black to fix code formatting issues - Run isort to fix import sorting issues - Ensure all linting checks pass in CI pipeline
- Change test to use set comparison instead of list order comparison - Question set order can vary based on filesystem read order - Test now focuses on content rather than specific ordering
- Remove trailing spaces from docstrings and comments - Fix formatting issues that were causing CI black failures - Ensure all files pass black formatting checks
- Add pyproject.toml with isort black profile - Set consistent line length (88) for both tools - Resolve formatting conflicts between black and isort - Ensure CI linting passes with both tools
- Add missing trailing commas in function parameters - Ensure black formatting compliance - Fix CI formatting issues
- Move logger definition before its usage - Fix flake8 F821 error: undefined name 'logger' - Ensure proper import order for logging
YauheniHuryn
pushed a commit
that referenced
this pull request
Feb 3, 2026
…nsets feat: consolidate question sets architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Add mountain peak themed question sets (Denali, Kilimanjaro) • Add shortcut field to all question sets (ev, tcfd, denali, kilimanjaro) • Consolidate to single source: report_analyst/questionsets/ • Remove hardcoded question set names across all UIs • Implement dynamic loading via QuestionSetLoader
• Add 100% test coverage for question loader functionality • Update all imports from app.* to report_analyst.* • Update .gitignore to exclude temp files and artifacts