fix: correct generated code for apply-to-all lookup definitions#805
Merged
chrispcampbell merged 7 commits intomainfrom Apr 14, 2026
Merged
fix: correct generated code for apply-to-all lookup definitions#805chrispcampbell merged 7 commits intomainfrom
chrispcampbell merged 7 commits intomainfrom
Conversation
ToddFincannonEI
approved these changes
Apr 14, 2026
Collaborator
ToddFincannonEI
left a comment
ToddFincannonEI
left a comment
There was a problem hiding this comment.
Good to fix this up for 1.0, even if we can attribute it to user error. It made me wonder whether we're doing this in EPS, which is so heavily subscripted, but fortunately we are not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #642
@ToddFincannonEI: This is the second of three today. (I have a few more perf fixes on the way, but I will save those for later in the week.) See issue for details.
AI disclosure
I manually wrote the test cases first. I then used Claude Code (Opus 4.6) to investigate a fix. Its first attempt was more complicated than it needed to be. I eventually simplified it, recognizing that the existing variable names were fine and that we just needed to omit the for loops in
declmode.