Skip to content

Conversation

@upgradingdave
Copy link
Contributor

@martinklepsch
Copy link
Member

Thanks @upgradingdave, will merge this soon and cut a new release :)
Glad you figured the problem out and took the time to create a PR! 👍

@martinklepsch
Copy link
Member

Thanks @upgradingdave for improving the externs and for leaving a note for others :)

There is a Creating Externs page in the wiki which elaborates a bit more on that. If you have ideas how to improve that your contribution would be welcome! :-)

Probably the visibility of the wiki could also be improved — were you aware of that page?

@upgradingdave
Copy link
Contributor Author

Hi Martin, yes, the "Creating Externs" page was very useful. In fact, that
page helped me to figure out that the leaflet externs file was probably
originally created using the tool found here:
http://www.dotnetwise.com/Code/Externs/index.html.

Once I figured that out, I realized that tool does a good job of adding top
level methods (such as L.map, for example), but it doesn't appear to
recursively add nested symbols (such as L.map.setView, etc).

The cljsjs project really makes the matter of dealing with extern files a
whole lot easier, thanks much for all your help!

Dave

On Mon, May 4, 2015 at 2:48 PM, Martin Klepsch notifications@github.com
wrote:

Thanks @upgradingdave https://github.com/upgradingdave for improving
the externs and for leaving a note for others :)

There is a Creating Externs
https://github.com/cljsjs/packages/wiki/Creating-Externs page in the
wiki which elaborates a bit more on that. If you have ideas how to improve
that your contribution would be welcome! :-)

Probably the visibility of the wiki could also be improved — were you
aware of that page?


Reply to this email directly or view it on GitHub
#111 (comment).

Preferred Version LLC
m. 703.989.3562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants