rename all occurences of React.ReactComponent to React.Component#287
Closed
thheller wants to merge 1 commit intocljsjs:masterfrom
thheller:react-externs-reactcomponent
Closed
rename all occurences of React.ReactComponent to React.Component#287thheller wants to merge 1 commit intocljsjs:masterfrom thheller:react-externs-reactcomponent
thheller wants to merge 1 commit intocljsjs:masterfrom
thheller:react-externs-reactcomponent
Conversation
Contributor
|
This fix is critical for using cljsjs.react-0.14.0 in production |
Member
|
@thos37 I haven't merged this yet because I was waiting for confirmation that this change is correct, understanding your comment here as confirmation I merged and pushed it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In React the ES6 class is available under
React.Componentand notReact.ReactComponent.Not 100% sure but I think
React.ReactComponentis incorrect. I ran into this when:advanced:compiling something and someReactfunctions got renamed on my components.om.nextships with a basically empty externs that hides this issue [1], but I think if the name is changed to problem should go away.Would be nice if someone could verify.
[1] https://github.com/omcljs/om/blob/master/src/main/om/externs.js