WIP: Start SDK tests for delete_all_by_eq_bsatn #2164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is almost entirely redundant with #2146 (merged just before and I didn't see) except that I wanna add a few more tests to that. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This API used to be unimplemented and the SDK tests did not exercise it. Now it is implemented but while playing with blackholio I noticed the C# implementation was wrong.
For now I am going to fix blackholio by avoiding use of this API for now, but we should also correct the implementation and test it.
API and ABI breaking changes
None
Expected complexity level and risk
0
Testing
Working on adding tests. If someone is more familiar with the SDK tests I would appreciate help amending them.