consult, prioritize event.request_id over database_update.request_id (#2729)#3368
Merged
bfops merged 5 commits intoclockworklabs:masterfrom Apr 30, 2026
Conversation
|
|
gefjon
reviewed
Oct 14, 2025
cloutiertyler
approved these changes
Apr 14, 2026
Collaborator
|
Hi @apron-manlike0o, are you able to update this PR so that the commits are linked to your github user? Otherwise our CLA bot will not allow us to merge the PR for licensing reasons. |
auto-merge was automatically disabled
April 29, 2026 18:28
Head branch was pushed to by a user without write access
apron-manlike0o
force-pushed
the
bugfix/2729/fix-incorrect-request-id-on-reducer-call-error
branch
2 times, most recently
from
3590d3f to
3ebf8a2
Compare
Co-authored-by: Phoebe Goldman <phoebe@goldman-tribe.org> Signed-off-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> (cherry picked from commit 857bcd5)
apron-manlike0o
force-pushed
the
bugfix/2729/fix-incorrect-request-id-on-reducer-call-error
branch
from
3ebf8a2 to
fbb1db3
Compare
Contributor
Author
|
bfops
reviewed
Apr 29, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
Collaborator
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly addresses issue #2729.
On error, the
database_updateis created by a default pattern which always produces arequest_idofNone.However the event struct holds the true
request_id, hence it should prioritize that request_id value.