Skip to content

align UUID reducer examples with allowed signatures#3999

Merged
cloutiertyler merged 6 commits intoclockworklabs:masterfrom
GEFNENEN:master
Apr 27, 2026
Merged

align UUID reducer examples with allowed signatures#3999
cloutiertyler merged 6 commits intoclockworklabs:masterfrom
GEFNENEN:master

Conversation

@GEFNENEN
Copy link
Copy Markdown
Contributor

Description of Changes

  • Corrected UUID v4/v7 reducer documentation examples to use valid reducer signatures returning ()/Result<(), E>

API and ABI breaking changes

  • None

Expected complexity level and risk

  • 1 (doc example corrections only)

Testing

  • Not run (docs-only change)
  • Please review documentation formatting and correctness

Signed-off-by: miXin <52082254@qq.com>
align UUID reducer examples with allowed signatures
Copilot AI review requested due to automatic review settings January 12, 2026 07:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the UUID reducer documentation examples to align with the valid reducer signatures (() or Result<(), E>). The changes ensure the example function signatures match the allowed return types for reducers.

Changes:

  • Updated UUID v4 reducer example to return () instead of Uuid
  • Updated UUID v7 reducer example to return Result<(), Box<dyn std::error::Error>> instead of Result<Uuid, ...>
  • Added Ok(()) return statement to complete the UUID v7 example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/bindings/src/lib.rs Outdated
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 12, 2026

CLA assistant check
All committers have signed the CLA.

@GEFNENEN GEFNENEN closed this Mar 3, 2026
@GEFNENEN GEFNENEN reopened this Mar 3, 2026
@bfops
Copy link
Copy Markdown
Collaborator

bfops commented Mar 3, 2026

Thank you for opening a PR to fix this! I had one comment but otherwise LGTM.

@cloutiertyler cloutiertyler enabled auto-merge April 14, 2026 21:51
@cloutiertyler cloutiertyler added this pull request to the merge queue Apr 27, 2026
Merged via the queue into clockworklabs:master with commit b150cf6 Apr 27, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants