Trigger view refresh when a WASM procedure commits a transaction#4301
Open
joshua-spacetime wants to merge 1 commit intomasterfrom
Open
Trigger view refresh when a WASM procedure commits a transaction#4301joshua-spacetime wants to merge 1 commit intomasterfrom
joshua-spacetime wants to merge 1 commit intomasterfrom
Conversation
| .collect() | ||
| } | ||
|
|
||
| pub(crate) fn run_query_for_view( |
Collaborator
Author
There was a problem hiding this comment.
No new code was added here. It was just extracted into a helper for reuse in procedure view refresh.
joshua-spacetime
force-pushed
the
joshua/procedures-dont-trigger-views
branch
from
2bc26c8 to
8cd7b38
Compare
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR fixes the bug where WASM procedures could commit a transaction without refreshing affected materialized views, which caused view-backed subscriptions to miss updates from procedure writes.
The equivalent changes for V8 will be made in a separate patch.
API and ABI breaking changes
None
Expected complexity level and risk
3
This was not a simple translation of the reducer code path, because reducers are run in a single transaction whereas procedures can have multiple transactions via
with_txand views must be refreshed with each transaction instead of once at the end of the procedure. This required refresh to be inserted into the syscall itself which required some extra plumbing. Mainly that we had to attach the validatedModuleDefto theWasmInstanceEnv. This should not affect hotswapping because we instantiate an entirely newWasmInstanceEnvin that case.Testing