Skip to content

js macro change#4308

Closed
Shubham8287 wants to merge 2 commits intoshub/case-conversionfrom
shub/ts-accessors
Closed

js macro change#4308
Shubham8287 wants to merge 2 commits intoshub/case-conversionfrom
shub/ts-accessors

Conversation

@Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Feb 16, 2026

Description of Changes

Typescript changes:

  • rename index name to accessor
  • name provided with table & view passed as explicit name to RawModuleDefV10, and do not overrride accessor names.

API and ABI breaking changes

Breaks existing modules.

Expected complexity level and risk

2

Testing

CIs

@Shubham8287 Shubham8287 changed the title js bindings js macro change Feb 16, 2026
@Shubham8287 Shubham8287 changed the base branch from master to shub/case-conversion February 16, 2026 20:15
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

@Shubham8287
Copy link
Contributor Author

This needs case-conversion to pass the CI , I am merging the changes into original PR -#4263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments