Improve spacetime build for typescript#4330
Merged
coolreader18 merged 2 commits intomasterfrom Feb 18, 2026
Merged
Conversation
spacetime build for typescript.spacetime build for typescript
cloutiertyler
approved these changes
Feb 17, 2026
Contributor
cloutiertyler
left a comment
There was a problem hiding this comment.
Beautiful! This is a great fix.
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
# Description of Changes Forgot to push something for #4330, whoops. Now it will actually give the output in that PR. # Testing - [x] Already tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This fixes the confusing error encountered by @gefjon:
After:
And also runs
tsc, so that modules with type errors aren't silently published. Perhaps we want a--skip-tscso that people can run anyway and get runtime errors?Expected complexity level and risk
2
Testing