Use accessor_name for generated identifiers in codegens#4337
Closed
cloutiertyler wants to merge 1 commit intomasterfrom
Closed
Use accessor_name for generated identifiers in codegens#4337cloutiertyler wants to merge 1 commit intomasterfrom
cloutiertyler wants to merge 1 commit intomasterfrom
Conversation
…degens Client code generators now use `accessor_name` instead of `name` for generated language identifiers (type names, filenames, method names, variable names). The `name` field continues to be used for protocol/wire communication (table names sent over WebSocket, reducer names in schema, match arms on wire data). Closes #4324
This was
linked to
issues
Feb 18, 2026
Collaborator
|
This has been merged into #4263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accessor_nameinstead ofnamefor generated language identifiers (type names, filenames, method names, variable names)namefield continues to be used for protocol/wire communication (table names sent over WebSocket, reducer names in schema, match arms on wire data)iter_table_names_and_typesinutil.rsto return bothnameandaccessor_nameCloses #4324
Test plan
cargo build -p spacetimedb-codegencompilescargo test -p spacetimedb-codegen— all 3 codegen tests pass (TypeScript, Rust, C#)cargo fmt— all files formattedaccessor_name == namealways, so this is a no-op for existing modules