Re-enable bench tests for case conversion PR#4352
Merged
Shubham8287 merged 2 commits intoshub/case-conversionfrom Feb 19, 2026
Merged
Re-enable bench tests for case conversion PR#4352Shubham8287 merged 2 commits intoshub/case-conversionfrom
Shubham8287 merged 2 commits intoshub/case-conversionfrom
Conversation
Re-enable the four bench tests that were commented out: - test_basic_invariants_sqlite - test_basic_invariants_spacetime_raw - test_basic_invariants_spacetime_module_rust - test_basic_invariants_spacetime_module_csharp Restore serial_test import and #[serial] attributes for module tests. Remove dead_code allow on test_basic_invariants. Compiles clean with cargo test -p spacetimedb-bench --no-run.
The default CaseConversionPolicy (SnakeCase) inserts underscores at letter-digit boundaries, e.g. u32 -> u_32. The SpacetimeModule bench backend must use these converted names when calling reducers and clearing tables, since the module schema applies case conversion to all identifiers. Add convert_case dependency to bench crate and apply Case::Snake conversion to the table name in create_table().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from
shub/case-conversion(#4263).Re-enables the four bench tests that were commented out during the case conversion work:
test_basic_invariants_sqlitetest_basic_invariants_spacetime_rawtest_basic_invariants_spacetime_module_rusttest_basic_invariants_spacetime_module_csharpRestores
serial_testimport and#[serial]attributes. Only changescrates/bench/src/lib.rs.Compiles clean locally (
cargo test -p spacetimedb-bench --no-run).cc @Shubham8287