Close the connection on errors for applied subscriptions#4378
Merged
clockwork-labs-bot merged 3 commits intomasterfrom Feb 22, 2026
Merged
Close the connection on errors for applied subscriptions#4378clockwork-labs-bot merged 3 commits intomasterfrom
clockwork-labs-bot merged 3 commits intomasterfrom
Conversation
cloutiertyler
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Until we have per-query storage, if we get a subscription error for a subscription that we have already applied, we don't know how to remove the data for that query from our cache. This change just kills the connection if that happens.
Expected complexity level and risk
1
Testing
This has some unit test coverage.