fix: Handle empty HTTP response body in procedure bindings#4386
Merged
gefjon merged 1 commit intoclockworklabs:masterfrom Feb 21, 2026
Merged
fix: Handle empty HTTP response body in procedure bindings#4386gefjon merged 1 commit intoclockworklabs:masterfrom
gefjon merged 1 commit intoclockworklabs:masterfrom
Conversation
`create_bytes_source()` returns `BytesSourceId::INVALID` for empty
response bodies, but `HttpClient::send()` unconditionally tries to
read the body source via `read_bytes_source_into()`, which panics
on the INVALID handle ("invalid source passed").
This affects any procedure making an HTTP request that returns an
empty body (e.g. HTTP 200 with no content).
Check for `BytesSource::INVALID` before reading, returning an empty
`Body` instead. This matches the existing pattern used for JWT
payloads in `bindings-sys` (line 1455).
The doc comment on `bytes_source_remaining_length` already warns:
"the special `BytesSource::INVALID` (zero) is always invalid.
Callers should check for that value before invoking this function."
gefjon
approved these changes
Feb 21, 2026
gefjon
added
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_bytes_source()in the host returnsBytesSourceId::INVALIDfor empty response bodies, butHttpClient::send()unconditionally reads the body source viaread_bytes_source_into(), which panics with"invalid source passed"BytesSource::INVALIDbefore reading, matching the existing pattern used for JWT payloads inbindings-sysTest plan
cargo check -p spacetimedbpassesBodyis returned🤖 Generated with Claude Code