Update Unreal SDK to websocket 2.0#4497
Open
JasonAtClockwork wants to merge 13 commits intomasterfrom
Open
Conversation
3 tasks
Contributor
Author
|
@jdetter I'll work with you on this for the version bump and make sure that is done and reset up once this is ready to merge. The changes have not been done yet so this comment will need to be resolved before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
API and ABI breaking changes
metadata is invalid instead of continuing past setup issues.
Expected complexity level and risk
3 - A large set of changes to update the websocket/message handling along with heavy codegen changes to handle multi-module support
Testing
Test coverage of the Unreal SDK will need expansion in a future ticket once our issues with flakiness on CI is resolved.
--module-prefixReview Question(s)
spacetime inithave made the tutorial a little confusing with pathing for the Unreal Blackholio tutorial. To fix though we'd have to update all the commands to be more explicit, or update the tutorialspacetime initto use--project-path .to keep pathing simpler, thoughts?