Include full error chain in procedure HTTP request errors#4610
Open
Shiven0504 wants to merge 2 commits intoclockworklabs:masterfrom
Open
Include full error chain in procedure HTTP request errors#4610Shiven0504 wants to merge 2 commits intoclockworklabs:masterfrom
Shiven0504 wants to merge 2 commits intoclockworklabs:masterfrom
Conversation
Walk the `source()` chain of `reqwest::Error` when converting to `NodesError::HttpError`, so users see the underlying cause (DNS failure, connection refused, timeout, TLS error, etc.) instead of just the opaque top-level "error sending request for url" message. Fixes clockworklabs#4608
Shiven0504
force-pushed
the
fix/http-error-chain
branch
from
133f735 to
ac0ac5f
Compare
gefjon
approved these changes
Mar 11, 2026
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
This is a big improvement, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an HTTP request fails inside a procedure, the error message only shows something like "error sending request for url (https://...)" with no details about what actually went wrong.
This change walks the full error chain so the message includes the root cause — things like DNS failures, connection refused, timeouts, etc.
Before: error sending request for url (https://httpbin.org/get)
After: error sending request for url (https://httpbin.org/get): error trying to connect: dns error: failed to lookup address information:
Fixes HTTP requests frequently fail with no information as to why #4608
Test plan