Clean up keynote-2 template README & DEVELOP#4624
Merged
clockwork-labs-bot merged 9 commits intomasterfrom Apr 17, 2026
Merged
Conversation
cloutiertyler
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Refresh this stale PR against current
master. Several original items were already applied upstream or conflict with recent keynote-2 work (#4616, #4647, #4678, #4682, #4698, #4703, #4743, #4745, #4753, #4757), so those are dropped. What remains is the still-relevant subset, rebased onto the current file structures.README.md:
pnpm run demoin Quick Demo (consistency with pnpm workspace)--concurrencyand--alphato demo options--separator todocker compose runbench exampleDEVELOP.md:
pnpm runthroughout (demo, prep, bench) instead ofnpm run--pass-through afterpnpm run bench(not needed with pnpm; matches the#4703testing examples)convex,spacetimedb,bun,postgres_rpc,cockroach_rpc,sqlite_rpc,supabase_rpc,planetscale_pg_rpc)docker compose runbench example to a single line with--separator; fixnpm prep→pnpm run prepsrc/opts.ts: (CLI parsing moved here in
#4703; original PR targeted the now-gone inline parsers incli.ts/demo.ts)parseBenchOptions: bench--secondsdefault1→10parseDemoOptions: demo--concurrencydefault10→50.env.example:
USE_DOCKER=1andSKIP_CONVEX=1so demo defaults (convex, spacetimedb) work out of the boxCONVEX_USE_SHARDED_COUNTER=1(still a supported knob, just off by default)Dropped as superseded by master
bottlnecked/thentypo fixes) — section was removed by#4753SPACETIME_METRICS_ENDPOINT→USE_SPACETIME_METRICS_ENDPOINT— master'ssrc/config.tsstill reads the original namesqlite→sqlite_rpc,postgres→postgres_rpc) — already corrected on masterAPI and ABI breaking changes
None.
Expected complexity level and risk
1 – Documentation and default-value changes. No functional changes to core logic.
Testing
pnpm installintemplates/keynote-2/succeedspnpm run bench --help/pnpm run demo --helprender with valid-connec