Merged
Conversation
We switched to using `async-channel` as the backing queue in 2b3aa5a, which allows to close the channel on the sender side without dropping the sender. This is unlike tokio channels, which require the sender to be dropped, or the receiver to request the channel to be closed. This allows to greatly simplify the async shutdown of a durability instance by simply awaiting the actor's `JoinHandle` instead of a complicated chain of notification primitives.
Shubham8287
approved these changes
Apr 15, 2026
Contributor
Shubham8287
left a comment
Shubham8287
left a comment
There was a problem hiding this comment.
This is much simplified indeed.
Shubham8287
reviewed
Apr 15, 2026
gefjon
approved these changes
Apr 15, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We switched to using
async-channelas the backing queue in 2b3aa5a,which allows to close the channel on the sender side without dropping
the sender. This is unlike tokio channels, which require the sender to
be dropped, or the receiver to request the channel to be closed.
This allows to greatly simplify the async shutdown of a durability
instance by simply awaiting the actor's
JoinHandleinstead of acomplicated chain of notification primitives.