Add path context to invalid TOML config errors#4815
Open
clockwork-labs-bot wants to merge 1 commit intomasterfrom
Open
Add path context to invalid TOML config errors#4815clockwork-labs-bot wants to merge 1 commit intomasterfrom
clockwork-labs-bot wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4749.
Summary
The old report was filed against a
spacetime.tomlpath from 1.11-era CLI flows. On currentmaster, the shared TOML config parser already returns parse failures, but the top-level error does not say which config file was invalid.This patch makes the shared TOML config loader add file-path context while preserving the underlying TOML span details, so users get an error like
invalid TOML syntax in ...followed by the parser's line and column information.Testing
cargo test -p spacetimedb-core parse_config_reports_the_invalid_file_path -- --nocapture