Re-land Replay extraction PRs#4893
Merged
clockwork-labs-bot merged 5 commits intomasterfrom Apr 27, 2026
Merged
Conversation
# Description of Changes Moves stuff out of `datastore.rs` and `committed_state.rs` that has to do with replay into its own module `replay.rs`. This also shaves 64 bytes off of `CommittedState` so that we don't continue carrying the cost of replay after it has finished. This is a more limited version / part 1 of #4055 which focuses on almost pure code motion so that we're more diligent and careful about the transition. Future PRs will continue with other parts of #4055. # API and ABI breaking changes None # Expected complexity level and risk 1, just simple and safe code motion. # Testing Covered by existing tests as this is code motion.
# Description of Changes Shaves another 32 bytes off of `CommittedState` by moving the last replay only map out of the type. # API and ABI breaking changes None # Expected complexity level and risk 2 # Testing Covered by existing tests.
# Description of Changes First two commits are code motion. The second commit fixes a mistake I made in a previous PR that made us use potentially several `ReplayCommittedState`s per `datastore.replay(..)`. More to come in terms of PRs; stay tuned. # API and ABI breaking changes None # Expected complexity level and risk 3
# Description of Changes Move the rest of replay logic to `mod replay`. Closes #4055. # API and ABI breaking changes None # Expected complexity level and risk 2 # Testing Just code motion.
Shubham8287
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
See the corresponding commits/PRs for descriptions.
API and ABI breaking changes
None
Expected complexity level and risk
1 -- individual PRs already reviewed.
Testing
No semantic changes.