fix: update seq table when migrating table.#4902
Merged
Shubham8287 merged 5 commits intomasterfrom Apr 27, 2026
Merged
Conversation
Centril
requested changes
Apr 27, 2026
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
Centril
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
MutTxId::add_columns_to_tablecreates new table but only copies sequences to in-memory state, which causesautoinccolumns to reset on restart.The existing implementation relies on
create_table_and_update_seqhelper, which only updates the sequence state in memory. This change ensures that theallocationis also persisted to the system table, keeping it consistent across restarts.API and ABI breaking changes
NA
Expected complexity level and risk
2
Testing
Added a test, which migrate table and checks for
autoinccolumn value without and with restart.