Keynote 2 benchmark updates & refinements#4997
Merged
Merged
Conversation
joshua-spacetime
requested changes
May 12, 2026
Contributor
joshua-spacetime
left a comment
There was a problem hiding this comment.
Need to update the numbers
Contributor
Author
@joshua-spacetime do you know what configuration we're using for these README #'s? CC @cloutiertyler |
…ult vals, methodology)
cloutiertyler
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #4978
Description of Changes
Methodology refresh of
templates/keynote-2/with retry-policy cleanup and updated benchmark reporting.src/scenario_recipes/rpc_single_call.ts(single-attempt call path).src/connectors/rpc/cockroach_rpc.ts.withTxnRetryin pg/crdb/supabase RPC servers).core/runner.ts. Each run emits atimeSeriesarray for warmup/decay/collapse analysis.--alpha 0,1.5(CSV),--runs N, and--prep-between-alphas, writing one JSON per(connector, alpha, run)tuple.start-bench.sh,stop-bench.sh,check-bench.sh,bench-stats.py,plot-bench.py.Methodology Notes
clients,pipelining,max_pool).Updated Results
Alpha = 0
Alpha = 1.5
Alpha = 0 PIPELINED TEST
API and ABI Breaking Changes
No engine API/ABI changes. Internal keynote-template shape changes only.
BenchOptions.alpha: number→alphas: number[].runs,prepBetweenAlphas.RunResultnow includes requiredtimeSeries.test-1-<connector>-a<alpha>-<timestamp>.json.Expected Complexity Level and Risk
3. Contained to
templates/keynote-2/, but cross-cutting across runner/CLI/connectors/RPC servers/scripts/docs.Testing
Reviewer smoke test: