Skip to content

Use IndexMap for mounts and validate duplicates [Namespaces Part 2]#5062

Merged
clockwork-labs-bot merged 4 commits into
masterfrom
alessandro/validate-module-mount-names
May 21, 2026
Merged

Use IndexMap for mounts and validate duplicates [Namespaces Part 2]#5062
clockwork-labs-bot merged 4 commits into
masterfrom
alessandro/validate-module-mount-names

Conversation

@aasoni
Copy link
Copy Markdown
Contributor

@aasoni aasoni commented May 18, 2026

Description of Changes

  • Replace ModuleDef mounts type with IndexMap rather than Vec to explicitly require name uniqueness
  • Validate mount name uniqueness

API and ABI breaking changes

No

Expected complexity level and risk

2 - Fairly simple change to new (as of yet unused) module def type

Testing

  • Added a test to check that the duplicate name check is working correctly

@aasoni aasoni enabled auto-merge May 20, 2026 15:20
@joshua-spacetime joshua-spacetime linked an issue May 20, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough. Good stuff.

@aasoni aasoni added this pull request to the merge queue May 21, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 21, 2026
@aasoni aasoni added this pull request to the merge queue May 21, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 21, 2026
@clockwork-labs-bot clockwork-labs-bot added this pull request to the merge queue May 21, 2026
Merged via the queue into master with commit 4b46617 May 21, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespaces

3 participants