fix unity-testsuite: clear intermediate Godot build state#5133
Merged
Conversation
262af7d to
0a9ae13
Compare
unity-testsuite: clear intermediate Godot build state
bfops
reviewed
May 27, 2026
bfops
reviewed
May 27, 2026
bfops
reviewed
May 27, 2026
ec49780 to
2de1938
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of Changes
Harden
cargo regen csharp dllsagainst flaky Godot restore/build state in the Unity test suite.I suspect this flake is runner specific. Some Unity runners appear to have incomplete Godot package state, where
sdks/csharp/packages/godotsharpexists but is missingGodotSharp.dll. In that state, NuGet can still report restore success and generate aproject.assets.jsonthat containsGodotSharpmetadata but no usable compile asset.The regen flow now removes the Godot MSBuild intermediate directory (
sdks/csharp/obj~/godot) before restoringSpacetimeDB.ClientSDK.Godot.csproj. It also clears the targetedGodotSharppackage cache (sdks/csharp/packages/godotsharp) so NuGet cannot reuse a partially restored package missingGodotSharp.dll.After restore,
regenparsesproject.assets.jsonand verifies thatGodotSharpis present and that the referencedGodotSharp.dllexists before runningdotnet pack --no-restore.This should either prevent the flaky missing-
Godotnamespace failure, or fail earlier with a clearer restore/package-state error.NOTE/WARNING: This code was entirely AI generated.
API and ABI breaking changes
N/A
Expected complexity level and risk
~
Testing
unity-testsuitepasses (I ran it at least 5 times to try to get it scheduled to different runners)