Drop tps threshold for rust keynote-2 ci check#5159
Merged
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The keynote benchmark check has had a couple spurious failures in CI recently, namely for the rust module. I set a higher TPS threshold for rust than I did for typescript since rust is a bit faster, but it looks like the threshold I set is within the margin of error, so this change drops it to 275K - exactly what it is for typescript.
A failure now almost certainly represents a real performance regression and requires deeper investigation.
API and ABI breaking changes
N/A
Expected complexity level and risk
0 (one liner)
Testing
Should have no more spurious failures for this CI job.