Skip to content

chore: upgrade map.clojure-china toolchain#24

Open
tiye wants to merge 2 commits intomainfrom
updates
Open

chore: upgrade map.clojure-china toolchain#24
tiye wants to merge 2 commits intomainfrom
updates

Conversation

@tiye
Copy link
Copy Markdown
Member

@tiye tiye commented Apr 11, 2026

Summary

  • migrate the project from legacy Calcit manifests to deps.cirru
  • upgrade Yarn, Vite, GitHub Actions, and Calcit CLI integration
  • switch CI to the current Corepack plus immutable install flow

Validation

  • caps outdated --yes
  • caps
  • yarn install --immutable
  • cr js
  • yarn vite build --base=./

Copilot AI review requested due to automatic review settings April 11, 2026 14:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the project toolchain and build/CI flow by migrating Calcit manifests to deps.cirru, moving to Yarn 4 (Corepack), and updating the frontend build stack (Vite) plus GitHub Actions integration.

Changes:

  • Replace legacy Calcit manifests (calcit.cirru, package.cirru) with deps.cirru and bump Calcit CLI/procs versions.
  • Upgrade Yarn lockfile format (Yarn Berry) and Vite, and add Yarn configuration for node-modules linking.
  • Update CI workflow to use Corepack + yarn install --immutable and newer Calcit setup action.

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
yarn.lock Regenerated lockfile for Yarn Berry and updated dependency graph (incl. Vite/Calcit upgrades).
package.json Adds packageManager + build scripts; upgrades vite and @calcit/procs.
package.cirru Removes legacy dependency manifest.
deps.cirru Adds new Calcit deps/config manifest (init/reload fns, pinned Calcit deps).
calcit.cirru Removes legacy Calcit manifest/source bundle.
.yarnrc.yml Configures Yarn to use node-modules linker.
.gitignore Ignores macOS .DS_Store and some Yarn artifacts.
.github/workflows/upload.yaml Updates CI to Corepack + immutable installs and newer Calcit setup action.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines 18 to 21
"devDependencies": {
"bottom-tip": "^0.1.5",
"vite": "^6.4.2"
"vite": "^8.0.8"
},
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bottom-tip is imported from application runtime code (see compact.cirru), so keeping it under devDependencies can break builds in environments that install production deps only (e.g., yarn install --production) or confuse dependency intent. Move it to dependencies (and keep only build tooling like vite in devDependencies).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 0e82786 — moved bottom-tip from devDependencies to dependencies in package.json so runtime imports are available in production installs.

Comment thread .github/workflows/upload.yaml
@tiye tiye requested a review from a team April 11, 2026 15:16
Copilot finished work on behalf of tiye April 12, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants