Don't send debugger message if the break won't prompt #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
If we manage to have something like razum2um/clj-debugger#12, then there will a better way to do all of this. But in the meantime, this PR should patch the issue. |
bbatsov
added a commit
that referenced
this pull request
Apr 11, 2015
Don't send debugger message if the break won't prompt
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging something else I noticed a bug in the debugger.
If the user hits
cto continue without stopping, clj-debugger'sbreakstatements don't trigger anymore (as expected) but we were still sending the debugger message for cider to "prepare" for a break.This fixes that.